-
Notifications
You must be signed in to change notification settings - Fork 8
Time stamp in EpochPosition #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My thoughts: re: Problem
re: Solution(s)
|
I note an agreement for not using |
The implementation of primitive type representations, especially with Mivot is not clear for me. I get it as a complex type, giving the representation (e.g. ISO), wrapping a primitive value (an ISO string). |
The epoch is often given as a year (e.g. 2015.5) without any frame reference. This is not a time offset, but an absolute date. Of course, it can be argued that any absolute coordinate is an offset from the origin of the system, but if you say 2015.5, everyone understands it as 6 months after the year 2015 in the christian calendar, not as a 2015.5 years offset. For the seconds, I've in mind the Unix time which is the number of seconds from 1970-01-01 (https://www.unixtimestamp.com/). I admit that I've no concrete astronomical example for this, and that his representation can be discarded. |
The current proposal looks like this (Seconds should be pushed out)
All of the |
Problem
There are 2 issues with
EpochPosition.epoch
, which is currently typed as aCoords:Epoch
primitive type (B/J<year>
)If the
EpochPosition.epoch
attribute refers to one of these serializations, the model will miss the serialization mode.EpochPosition
.Solution
To solve these 2 issues,
EpochPositio.Epoch
can be typed as acoords:TimeInstant
(see standard P 18) which is an abstract type with 3 subtypes currently supported: JD, MJD and ISO.In addition to this, Mango should extend
coords:TimeInstant
with 2 types:Years
andSeconds
Proposed actions
coords:TimeInstant
in Mango to avoid mixing components of different models in one Mango class (see Error types and relation to Measurement model Uncertainty #60)ivoa:real
subtypes:Year
andSeconds
EpochPosition.epoch
as amango:TimeInstant
The text was updated successfully, but these errors were encountered: