Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to Go 1.22.5 to fix vulnerabilities #90

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

strausmann
Copy link
Contributor

@itzg
Copy link
Owner

itzg commented Jul 9, 2024

That vulnerability does not affect this application. I run weekly govulncheck's that avoid false negatives and wasted time and effort.

https://github.com/itzg/mc-monitor/actions/runs/9824443576/job/27218087754#step:2:150

And I just now re-ran it to be sure.

@itzg
Copy link
Owner

itzg commented Jul 9, 2024

https://go.dev/blog/vuln

@strausmann
Copy link
Contributor Author

I only ever respond to the poor security rating of my Docker images here.
Here is an example:
image

@strausmann
Copy link
Contributor Author

Renovate automatically builds a new Docker image for me when a dependency has a new release that is intended to solve a CVE.

@itzg
Copy link
Owner

itzg commented Jul 9, 2024

Renovate automatically builds a new Docker image for me when a dependency has a new release that is intended to solve a CVE.

How does Renovate know that mc-monitor, etc is a dependency of your image? Looking at the docs it seems to only do what dependabot does which is look at base image semantic versions.

Meanwhile, I'm quite frustrated with the mismatch in philosophy of docker scout and govulncheck. I guess running govulncheck is pointless if docker scout is going to flag false negatives anyway.

@itzg
Copy link
Owner

itzg commented Jul 9, 2024

Sorry for taking my frustration out on you. I'll merge this PR and cut a release, but I'm still not happy about the govulncheck vs docker scout thing.

@itzg itzg merged commit 7a11054 into itzg:master Jul 9, 2024
2 checks passed
@strausmann
Copy link
Contributor Author

https://git.strausmann.de/minecraft/bedrock-connect/-/blob/main/renovate.json?ref_type=heads

I made this possible with the config. have focused on the configuration of home assistant addons. in my test last week it had worked. tonight I will see if it is detected correctly.

@strausmann
Copy link
Contributor Author

Sorry to leave my frustration on you. I'm going to merge this PR and cut a release, but I'm still not happy about the Gouverncheck vs. Docker Scout thing.

I can understand that this different test produces unnecessary work.

@itzg
Copy link
Owner

itzg commented Jul 9, 2024

https://git.strausmann.de/minecraft/bedrock-connect/-/blob/main/renovate.json?ref_type=heads

I made this possible with the config. have focused on the configuration of home assistant addons. in my test last week it had worked. tonight I will see if it is detected correctly.

Thanks! That's exactly the customization I was hoping you were using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants