Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty importing new effects #4

Closed
krillme opened this issue Feb 7, 2025 · 3 comments
Closed

Difficulty importing new effects #4

krillme opened this issue Feb 7, 2025 · 3 comments

Comments

@krillme
Copy link

krillme commented Feb 7, 2025

I'm attempting to add the following effects to ReShade

DFTAA.fx
FSR1_2X.fx
cMotionBlur.fx
MartysMods_SMAA.fx

and while I did eventually get them to work, it wasn't intuitive at all. For some reason ReShade doesn't seem to be searching recursively or detecting new effects when they're placed inside the already existing folders.

Your plugin seems to setup some folders, namely "External_shaders" and "ReShade_shaders", looking at their file structure and the search path of ReShade inside an application I believe the contents of these folders either get copied or symlinked to a new "reshade-shaders" folder inside whatever game it was installed to. But when I placed shaders inside the "External_shaders" folder or the "Merged" folder inside the "ReShade_shaders" folder, they didn't seem to get transferred as they didn't appear in ReShade. I was able to get them to load by placing them in the "External_shaders" folder and then adding every folder inside as a search path, but I reckon they could be put in any folder if you add it and all subfolders as search paths.

This could be a bug or simply a lack of documentation explaining how the plugin manages shaders. Is there a specific folder to add shaders I've missed maybe?

@itsOwen
Copy link
Owner

itsOwen commented Feb 7, 2025

Yes the external shaders folder is for loading stuff separately. But I can do what you want. I will keep this in mind. If you have any more suggestions do let me know.

@itsOwen itsOwen added the enhancement New feature or request label Feb 7, 2025
@krillme
Copy link
Author

krillme commented Feb 8, 2025

So I'm still a bit confused, as the shaders I put in the external shaders folder were not loaded. I discovered how to make ReShade search folders recursively by adding "**" to the end of the search path, but this causes many of the effects to be loaded 2, 3, sometimes even 4 times due to how the folders are set up. What would be the ideal way to add custom effects? Put them in the Merged folder?

@Vaddum
Copy link

Vaddum commented Feb 9, 2025

Yes the custom .fx files have to be put in the "Merged" folder in order to be loaded properly. However beware that some custom effects could create some errors with the default ones.

@itsOwen itsOwen removed the enhancement New feature or request label Feb 13, 2025
@itsOwen itsOwen closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants