Added GitHub Actions templates and tool configuration files #104
+1,685
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
4 times, most recently
from
db03311 to
d381d1a
Compare
turegjorup
reviewed
Mar 19, 2025
turegjorup
reviewed
Mar 19, 2025
turegjorup
reviewed
Mar 19, 2025
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
3 times, most recently
from
f50b20c to
a6228d5
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
14 times, most recently
from
ceb3413 to
8985de3
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
ded630d to
49008d8
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
49008d8 to
12386c3
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
50fa28f to
c01409a
Compare
rimi-itk
requested review from
cableman,
yepzdk,
martinyde,
tuj,
sinejespersen,
Anna-itk,
lelyra,
lilosti,
jekuaitk,
jeppekroghitk,
turegjorup and
MadNicGit
| desc: "Lint shell scripts" | ||
| cmds: | ||
| # https://github.com/koalaman/shellcheck?tab=readme-ov-file#installing | ||
| - docker run --rm --volume "$PWD:"/mnt koalaman/shellcheck:stable {{.GLOB}} |
There was a problem hiding this comment.
What about good old peterdavehello/shellcheck https://github.com/PeterDaveHello/docker-shellcheck
There was a problem hiding this comment.
https://hub.docker.com/r/koalaman/shellcheck “is the official Docker image for ShellCheck”.
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
3b69e0d to
1093f59
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
f604ef4 to
40e61eb
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
40e61eb to
b53a8fc
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
5a8f520 to
85aeed6
Compare
rimi-itk
force-pushed
the
feature/github-actions-templates
branch
from
85aeed6 to
042a574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=4062#/tickets/showTicket/4062
Note
This is still work in progress and currently an experiment to learn how this can be done.
Adds templates for GitHub Actions workflows that are copied to projects when installing and updating templates. The templates sit in the
github/workflows/folder and aresymlink'ed into project templates. A small change has been made in itkdev-docker-compose to create actual files rather than symlinks when installing templates in a project.Template configuration files for tools used in actions sit in the
configfolder.See docs/girhub-actions-templates.md for details on what's actually going on.
To dos
itkdev-docker-compose template:updateto make it easy to update the templates in a project (based onITKDEV_TEMPLATE=drupal-10, say, in.env, say). Command added in Added template:update command #106.docker compose runogrdocker runin actions.prettierignore