Skip to content

chore(icon): lint SVG files on pre-commit #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

chore(icon): lint SVG files on pre-commit #928

merged 1 commit into from
Apr 7, 2025

Conversation

daneah
Copy link
Member

@daneah daneah commented Apr 6, 2025

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?
  • Component status page up to date?

What does this change address?

Resolves #872

@daneah daneah requested a review from a team as a code owner April 6, 2025 14:36
@daneah daneah requested review from sirrah-tam, mtorres3 and satya-achanta-venkata and removed request for a team April 6, 2025 14:36
Copy link

changeset-bot bot commented Apr 6, 2025

⚠️ No Changeset found

Latest commit: e0fb139

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 6, 2025

size-limit report 📦

Path Size
packages/pharos/lib/index.js 72.2 KB (0%)

@daneah daneah merged commit d619ee5 into develop Apr 7, 2025
7 checks passed
@daneah daneah deleted the fix/svg-lint branch April 7, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVGs are not linted during the pre-commit checks
2 participants