feat(leo): Add Leo definition #127
Conversation
|
Marking this as a draft until Leo will not be available under |
| LEO_SERVICE_HOST: "{{ .Release.Name }}-leo" | ||
| LEO_SERVICE_PORT: "{{ .Values.studioLeo.service.port }}" | ||
| LEO_ENCODING: "utf-8" | ||
| LEO_API_PATH_PREFIX: "{{- if and .Values.global.basePath (not (eq .Values.global.basePath "/")) }}{{ include "studio.basePath" . }}/{{- end }}leo" |
There was a problem hiding this comment.
@dacbd Kindly ask you to check if the configuration is valid 😃 especially LEO_API_PATH_PREFIX - I configure it for support custom basePath
There was a problem hiding this comment.
Looks right to me, but the question is, where do we set the base path for the LEO server itself? cc @dacbd
There was a problem hiding this comment.
Actually, I'm not even sure that LEO needs to worry about base path since it's not publicly exposed, right?
There was a problem hiding this comment.
@jesper7 is correct, the leo api is internal only, so while the API was built to be able to have some prefix we don't need to set anything. I would leave it empty for leo to use its default.
| LEO_SERVICE_HOST: "{{ .Release.Name }}-leo" | ||
| LEO_SERVICE_PORT: "{{ .Values.studioLeo.service.port }}" | ||
| LEO_ENCODING: "utf-8" | ||
| LEO_API_PATH_PREFIX: "{{- if and .Values.global.basePath (not (eq .Values.global.basePath "/")) }}{{ include "studio.basePath" . }}/{{- end }}leo" |
There was a problem hiding this comment.
Looks right to me, but the question is, where do we set the base path for the LEO server itself? cc @dacbd
mjasion
force-pushed
the
add_leo
branch
2 times, most recently
from
d279db4 to
c8dd482
Compare
mjasion
force-pushed
the
add_leo
branch
2 times, most recently
from
95e72c5 to
29d294f
Compare
Fixes https://github.com/iterative/itops/issues/1773