generated from ita-social-projects/DevTemplate
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload the calculator logo #982
Open
KseniaGovorun
wants to merge
17
commits into
calculators-constructor
Choose a base branch
from
970-ability-upload-logo
base: calculators-constructor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f1f963a
Added association for logo
KseniaGovorun 98dc032
Added test
KseniaGovorun 4f47f52
Added patrial in show page
KseniaGovorun c215f3b
Added test for show page
KseniaGovorun b1d3c75
Fixed rubocop
KseniaGovorun 3d22504
Merge calculators-constructor into current branch
KseniaGovorun a4c1f1c
Changed new page
KseniaGovorun 9ac9c89
Added by default image
KseniaGovorun a57e700
Added placeholder
KseniaGovorun e3a6762
Fixed rubocop
KseniaGovorun 0d23767
Merge branch 'calculators-constructor' of github.com:ita-social-proje…
olexandervanzuriak d5550b4
Merge branch 'calculators-constructor' of github.com:ita-social-proje…
olexandervanzuriak 66b8d20
Added calcualtor image to show page and style image
olexandervanzuriak cd8fae1
Merge remote-tracking branch 'origin/calculators-constructor' into 97…
olexandervanzuriak fdac741
Chnage styling
olexandervanzuriak 37e3052
Change default logo_url logic
olexandervanzuriak 61ef4ab
Added test and change the logo image size
olexandervanzuriak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<% if @calculator.logo_picture.attached? %> | ||
<%= image_tag(@calculator.logo_picture.variant(resize_to_fill: [428, 307])) %> | ||
<% else %> | ||
<%= image_tag(@calculator.logo_placeholder) %> | ||
<% end %> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use constant for this dimension definition