WCAG on public pages #974
Merged
WCAG on public pages #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #974 +/- ##
========================================
Coverage 98.71% 98.71%
========================================
Files 71 71
Lines 1011 1011
========================================
Hits 998 998
Misses 13 13 ☔ View full report in Codecov by Sentry. |
alexy78
approved these changes
Nov 25, 2024
loqimean
requested changes
Nov 25, 2024
| <button data-action="click->burger#toggle" class="admin-menu-burger-button"> | ||
| <%= image_tag "icons/burger-menu-lines.svg", class: "block h-8 w-8", "data-burger-target": "iconLines" %> | ||
| <%= image_tag "icons/burger-menu-cross.svg", class: "block h-8 w-8 hidden", "data-burger-target": "iconCross" %> | ||
| <button data-action="click->burger#toggle" class="admin-menu-burger-button" aria-label="Toggle menu"> |
loqimean
force-pushed
the
develop
branch
4 times, most recently
from
03a3caf to
7d2dc81
Compare
loqimean
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code reviewers
Second Level Review
Summary of issue
Add WCAG(aria-label, alt, title) on public pages
Summary of change
added when it was missing
CHECK LIST