Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-with-entropy pipeline #1384

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

foxtacles
Copy link
Member

@foxtacles foxtacles commented Feb 13, 2025

Related to: isledecomp/reccmp#88

@foxtacles foxtacles changed the title Add built-with-entropy pipeline Add build-with-entropy pipeline Feb 13, 2025
@jonschz
Copy link
Collaborator

jonschz commented Feb 14, 2025

This looks like a great idea! I'd try to seed the randomness for the CI in order to keep the CI builds deterministic.

@foxtacles
Copy link
Member Author

foxtacles commented Feb 18, 2025

@jonschz I've added seed functionality to the script - in the CI builds, it will use the commit SHA as the base seed so given the same commit, we get the same determinstic / reproducible results.

@disinvite Do you think you can adapt the pipeline to the denoise script once it's ready? Right now it is only creating the build artifacts, but will still need to create the aggregation files for comparison, and then do the comparison.

@madebr If you could take a look at the CMake portion that would be great. Maybe there is a more idiomatic way of doing the same. The entropy.h should be applied to all compilation units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants