Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Workaround for duplicate decorators in def -> async def #65

Closed
wants to merge 2 commits into from

Conversation

MementoRC
Copy link
Contributor

@MementoRC MementoRC commented Dec 2, 2022

Related to: #55
Observation:
- When Asyncifing a decorated function, the decorators are duplicated
Understanding:
- In apply() method of_ReplaceCodeSegmentAction, the lines exclude the decorators (from position_for())
- Building the replacement is based on the context, which includes the decorators
- Replacing the lines slice with the replacement ends up duplicating the decorators
Proposal:
- A possible solution is to include the decorators in the lines since _resyntesize() works with the
context that includes the decorators

@MementoRC MementoRC deleted the branch isidentical:main December 3, 2022 00:21
@MementoRC MementoRC closed this Dec 3, 2022
@MementoRC MementoRC deleted the main branch December 3, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant