nix-appimage does not use follow for nixpkgs, causing two versions of nixpkgs #37
Labels
Comments
|
Thanks for opening your first issue here! 💖 |
|
Yeah, it broke in the past at some point and has since then been fixed. Actually, nah. You are right. The CI should catch build failures, and then it should be easy enough to split it up again. I am currently rewriting the entire packaging system (currently the closure also includes the docs for example). |
|
Thanks for the quick response. No worries at all, it's just a minor issue, take your time. |
isd-project
added a commit
that referenced
this issue
Feb 1, 2025
This release mainly focuses on improving the packaging side. `isd` now provides a desktop file and uses a standard size for the icon (fixes #29). This release will also be available on PyPI. The main reason for publishing to PyPI is to better support packaging for distros as mentioned in #18. Due to a naming clash on PyPI, the Python project has been renamed to `isd-tui`. However, the project will continue to be named `isd` and the executable will continue to be called `isd`! The Python wheel only includes the necessary files, including the `.desktop` file and icon. The `nix` derivation propagates the `.desktop` file and the icon and makes them available for Desktops of `nix` users. Due to a bug in `isd-appimage`, identical `nixpkgs` pins cannot be used for `isd` (#37 is blocked). This release also introduces _EXPERIMENTAL_ arm support! I do _not_ have access to an arm-based machine, and as such, I cannot actually test the arm-based `AppImage`. The `AppImage` was created by cross-compiling. However, I cannot run a cross-platform `AppImage` (should fix #36). Please let me know if it works for you or not 🙏 At least the arm-based `nix` derivation can be run with QEMU, and it seems to work. PS: This release also includes a workaround for a `Zellij` bug (fixes #34). Though upstream already has a bug-fix available until a new version has been published, `isd` will work around the Zellij issue.
|
As mentioned in the release notes, I cannot combine the locks, atm :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thank you for all the work you’ve put into this project! It’s greatly appreciated.
I noticed that when pinning nixpkgs, two different versions are required because nix-appimage does not use follow. This can lead to increased closure sizes.
Is there a particular reason why nix-appimage does not use follow? I tested locally by binding its nixpkgs to follow, and everything seems to work fine. If there are no known issues, would it be possible to update nix-appimage to follow the pinned nixpkgs version to avoid duplication?
https://github.com/ericukk/isd/blob/main/flake.nix#L32-L34
The text was updated successfully, but these errors were encountered: