Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negative tests #28

Merged
merged 3 commits into from
Dec 30, 2024
Merged

fix: negative tests #28

merged 3 commits into from
Dec 30, 2024

Conversation

Alex-GF
Copy link
Collaborator

@Alex-GF Alex-GF commented Dec 30, 2024

These are some points that need to be known when reviewing the PR:

  • All comments within the negative tests have been removed and now run the desired tests.
  • I have corrected the suite of real world pricing that were used to perform positive validation of the parsing process. Now, the dataset of real world pricing is up-to-date with the one used in Pricing4TS. In addition, I have parametrized their test suite, which had more than 120 hand-coded tests with similar assertions.
  • According to Pricing2Yaml, if the availableFor field is not present within an add-on, it will be available for al plans. That's why, instead of throwing an exception, I have implemented such behavior.
  • I have also modified a behavior related to version management. If the version field is not present within a Pricing2Yaml specification, it will throw an error.

Please, take this comments into consideration when modifying the documentation this week ;)

@Alex-GF Alex-GF requested a review from pgmarc December 30, 2024 16:45
@pgmarc pgmarc merged commit 22d56fe into feat/refactor-tests Dec 30, 2024
1 check passed
@Alex-GF Alex-GF deleted the fix/negative-tests branch January 8, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants