feat: refactor negative parsing test suite #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add script to merge negative cases csv `MergeCSV.java` - Remove extra csv files and add a general negative-cases.csv file - Some tests cases were not passing but commented them - Add extra test case for addOn.dependsOn and addOn.availableFor - Positive test suite not yet clean
Alex-GF
requested changes
Dec 29, 2024
There was a problem hiding this comment.
Good job! Just a couple of things I’d like to ask you before merging:
- I noticed that all the tests are negative cases, and the test suites with positive tests are brief and, in most cases, have tests with similar assertions hardcoded. Could you also transfer the positive tests from Pricing4TS to this repository in order to improve the robustness of the suite?
- Could you remove the
MergeCSV.javascript from the library before merging? While it was useful for completing this task more quickly, it won’t add value to the library in the future, will it? - Is it possible to add a “test_name” field or something similar to all CSVs, like those in Pricing4TS, in order to assign a name to each of the tests generated by the parameterized test? With this approach, if a test fails, we can pinpoint exactly which one is causing the issue. Right now, it seems that it would just indicate that the parameterized test has failed, but not which execution caused it.
Looking forward to your responses and changes before merging. 😉
Added to the codebase necessary validations to pass certain tests
fix: negative tests
- Some test were disable to pass ci (need a look) - Add some new test cases - Remove legacy tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MergeCSV.java