Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TAP device handling for ironcore-in-a-box #290

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

guvenc
Copy link
Collaborator

@guvenc guvenc commented Feb 11, 2025

Improve TAP device handling for ironcore-in-a-box.

Linux VF TAP devices are using the pattern dtapvf_X and the DPDK names use the pattern net_tapX.
So adjust the TAP device conversions accordingly similar to the way it is done for the PCI devices.

metalnet API consumers receive the linux names and dpdk grpc library calls use the DPDK name.

@guvenc guvenc requested a review from a team as a code owner February 11, 2025 16:52
@github-actions github-actions bot added size/S enhancement New feature or request labels Feb 11, 2025
@guvenc guvenc changed the title Imrpove TAP device handling for ironcore-in-a-box Improve TAP device handling for ironcore-in-a-box Feb 11, 2025
@guvenc guvenc force-pushed the feature/ironcore-box branch from 7f2a9ea to 0a23afe Compare February 11, 2025 17:34
@github-actions github-actions bot added size/M and removed size/S labels Feb 11, 2025
@guvenc guvenc force-pushed the feature/ironcore-box branch 3 times, most recently from 560a2ca to d0aeca7 Compare February 17, 2025 10:51
@github-actions github-actions bot added size/S and removed size/M labels Feb 17, 2025
@guvenc guvenc requested a review from byteocean February 17, 2025 12:10
Copy link
Contributor

@byteocean byteocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot added size/M and removed size/S labels Feb 17, 2025
@guvenc guvenc force-pushed the feature/ironcore-box branch 2 times, most recently from e850a66 to 90067bd Compare February 17, 2025 14:52
Signed-off-by: Guvenc Gulce <guevenc.guelce@sap.com>
@guvenc guvenc force-pushed the feature/ironcore-box branch from 90067bd to 4fa886f Compare February 18, 2025 07:50
@guvenc guvenc merged commit f18b6eb into main Feb 18, 2025
7 checks passed
@guvenc guvenc deleted the feature/ironcore-box branch February 18, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants