[AMDGPU] Do not rewrite or approximate math functions on ROCm #19970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
bjacob
force-pushed
the
no-approx-at-all-on-rocm
branch
from
4ae6121 to
35e4441
Compare
MaheshRavishankar
approved these changes
Feb 12, 2025
|
If CI passes that's a good indication for e2e correctness for now I think |
|
Interesting. It has compilation failures |
lialan
reviewed
Feb 13, 2025
| // CHECK: math.exp2 | ||
| // CHECK: math.expm1 | ||
| // CHECK: math.cbrt | ||
| // CHECK: math.erf |
There was a problem hiding this comment.
have we figured out the numerical issue with math.erf library function?
There was a problem hiding this comment.
We have (99%) figured that there was no issue with it, and the issues we ran into were caused by PolynomialApproximationPass being too coarse-grained and too convoluted, so that when we thought earlier that we were enabling/disabling math.erf approximation, we were also enabling/disabling a number of other things, unintentionally. This is what #19922 solved. Now in the present PR we are finally at a place where we have some fine-grained, well-defined levers to play with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On ROCm, we want to use the device library for all math functions.
This expands on #19969, which only concerned
math.erf.We only leave one category of rewrites enabled: the operand casts to f32. The ROCm device library internally performs the same for many math functions, but we leave that unchanged here for safety and because we seemed to have accuracy issues with an earlier attempt that was dropping that.
This PR needs careful accuracy testing on end-to-end workloads before merging.