[GPU] Set insertion point to last slice index operand in reshape and slice fusion #19959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysz00
reviewed
Feb 11, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
krzysz00
approved these changes
Feb 12, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Dialect/GPU/Transforms/Transforms.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Max191
force-pushed
the
fix-reshape-fusion-insertion-point
branch
from
0c70796 to
4efa1c8
Compare
Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Max191
force-pushed
the
fix-reshape-fusion-insertion-point
branch
from
4efa1c8 to
9ee47e7
Compare
hanhanW
pushed a commit
to hanhanW/iree
that referenced
this pull request
Feb 13, 2025
…slice fusion (iree-org#19959) Empty tensor elimination relies on dominance of SSA values when attempting to reuse buffers for slices of init operands. Ideally, empty tensor elimination should be able to handle this, but it is difficult to fix at that level. For now, this PR tries to avoid creating these dominance issues in the first place. --------- Signed-off-by: Max Dawkins <max.dawkins@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty tensor elimination relies on dominance of SSA values when attempting to reuse buffers for slices of init operands. Ideally, empty tensor elimination should be able to handle this, but it is difficult to fix at that level. For now, this PR tries to avoid creating these dominance issues in the first place.