[NFC][GPU] Simplify definitions of MMA attributes #19905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tablegen had some strange auto-generated polymorphism with implicit parsing of certain fields. None of it provided any benefit and is simplified down to just the MMA enum. Also replaces the enum with an enum parameter removing the extra `.getValue()` indirection when accessing the enum.
qedawkins
requested review from
MaheshRavishankar,
kuhar and
antiagainst
as code owners
bjacob
reviewed
Feb 5, 2025
compiler/src/iree/compiler/Codegen/Dialect/GPU/IR/IREEGPUAttrs.td
Outdated
Show resolved
Hide resolved
bjacob
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tablegen had some strange auto-generated polymorphism with implicit parsing of certain fields. None of it provided any benefit and is simplified down to just the MMA enum. Also replaces the enum with an enum parameter removing the extra
.getValue()indirection when accessing the enum.