Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC][GPU] Simplify definitions of MMA attributes #19905

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

qedawkins
Copy link
Contributor

The tablegen had some strange auto-generated polymorphism with implicit parsing of certain fields. None of it provided any benefit and is simplified down to just the MMA enum. Also replaces the enum with an enum parameter removing the extra .getValue() indirection when accessing the enum.

The tablegen had some strange auto-generated polymorphism with implicit
parsing of certain fields. None of it provided any benefit and is
simplified down to just the MMA enum. Also replaces the enum with an
enum parameter removing the extra `.getValue()` indirection when
accessing the enum.
@qedawkins qedawkins requested a review from bjacob February 5, 2025 13:22
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@qedawkins qedawkins enabled auto-merge (squash) February 5, 2025 15:37
@qedawkins qedawkins merged commit 0a2862c into iree-org:main Feb 5, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants