-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump llvm to llvm/llvm-project@c06d0ff806b7 #19903
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fbec87f
Bump LLVM to c06d0ff806b72b1cfbca6306a2bc4f5f2922b01b
hanhanW 040c153
Fixes for https://github.com/llvm/llvm-project/commit/956c0707d909849…
hanhanW e9e76b5
Revert https://github.com/llvm/llvm-project/commit/327d627066e6452b08…
hanhanW e9349b1
"fix" for PTX
hanhanW 9656a1f
Revert ""fix" for PTX"
hanhanW 0fa71e4
revert https://github.com/llvm/llvm-project/commit/de7438e472839df63e…
hanhanW 56fbed4
Switch DumpExecutableBenchmarks to use eliminateCommonSubExpressions
hanhanW a5fb31c
Remove cleanups (dynamic pass manager) from IREEBufferizeOp::apply
hanhanW 5ae461d
cherry-pick upstream fix
hanhanW f206357
revert https://github.com/llvm/llvm-project/commit/3a3377579f137a0a6e…
hanhanW ec9220a
post-fix for bufferizeOp issue
hanhanW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule llvm-project
updated
2870 files
Submodule torch-mlir
updated
7 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something in here broke the MSVC/Windows build: https://github.com/iree-org/iree/actions/runs/13196900742/job/36840094404#step:9:7647
I saw some recent changes to https://github.com/llvm/torch-mlir/blame/main/lib/Conversion/TorchToTosa/TosaLegalizeCommon.cpp and https://github.com/llvm/llvm-project/tree/main/mlir/include/mlir/Dialect/Tosa/Utils but I'm not sure what specifically
I'm also not sure why we build
TorchToTosa
at all in IREE, since we don't use it...?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch fixes for me locally... still not sure what triggered that failure though
The namespace code in torch-mlir is sketchy: https://github.com/llvm/torch-mlir/blob/52299e6a659e68879b2c656ffd82ae2a9d28afd8/include/torch-mlir/Dialect/Torch/IR/TorchTraits.h#L20-L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, TOSA is a non-optional dep of torch-mlir. We could carve it out with a
TORCH_MLIR_ENABLE_TOSA
like there already is forTORCH_MLIR_ENABLE_STABLEHLO
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent my fix/workaround upstream: llvm/llvm-project#126286