Another commit

iree-org · Jan 17, 2025 · 1a6f454 · 1a6f454
1 parent f9476e0
commit 1a6f454
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/compiler/src/iree/compiler/Codegen/Common/test/type_propagation_packing.mlir b/compiler/src/iree/compiler/Codegen/Common/test/type_propagation_packing.mlir
@@ -73,4 +73,4 @@ func.func @generic_op_i1_packed() {
 //   CHECK-DAG:       %[[ADD:.+]] = arith.addi %[[ARG0]], %[[ARG0]] : i1
 //       CHECK:       linalg.yield %[[ADD]]
 //       CHECK:   -> tensor<?xi1, #iree_encoding.packed_storage>
-//       CHECK:   flow.dispatch.tensor.store %[[GENERIC]], %[[OUT]]
+//       CHECK:   flow.dispatch.tensor.store %[[GENERIC]], %[[OUT]]
diff --git a/compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingAttrs.cpp b/compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingAttrs.cpp
@@ -291,11 +291,8 @@ EncodingAttr getEncodingAttr(RankedTensorType type) {
 
 bool hasPackedStorageAttr(Type type) {
   if (auto tensorType = dyn_cast<RankedTensorType>(type)) {
-    auto encoding = tensorType.getEncoding();
-    if (!encoding) {
-      return false;
-    }
-    return dyn_cast_or_null<PackedStorageAttr>(encoding) != nullptr;
+    return dyn_cast_or_null<PackedStorageAttr>(tensorType.getEncoding()) !=
+           nullptr;
   }
   return false;
 }

diff --git a/compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingTypes.h b/compiler/src/iree/compiler/Dialect/Encoding/IR/EncodingTypes.h
@@ -38,7 +38,8 @@ namespace mlir::iree_compiler::IREE::Encoding {
 /// Otherwise, returns null.
 EncodingAttr getEncodingAttr(RankedTensorType type);
 
-/// Returns true if the type contains packed_storage attribute.
+/// Returns true if the type is a RankedTensorType type and it contains
+/// packed_storage attribute.
 bool hasPackedStorageAttr(Type type);
 
 /// Returns the ContractionDimensions for the encoding user_indexing_maps.