Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running mypy via precommit with --install-type --non-interactive seem to silence some errors #1336

Open
Carreau opened this issue Feb 17, 2025 · 0 comments

Comments

@Carreau
Copy link
Member

Carreau commented Feb 17, 2025

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
mypy.....................................................................Passed

But:

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 62514712..06f52541 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -44,7 +44,6 @@ repos:
     hooks:
       - id: mypy
         files: ipykernel
-        args: ["--install-types", "--non-interactive"]
         additional_dependencies:
           [
             "traitlets>=5.13",
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

ipykernel/pylab/config.py:8: error: Unused "type: ignore" comment
[unused-ignore]
    from matplotlib_inline.config import *  # type:ignore[import-untyped] ...
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ipykernel/pylab/backend_inline.py:8: error: Unused "type: ignore" comment
[unused-ignore]
    from matplotlib_inline.backend_inline import *  # type:ignore[import-u...
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~...
ipykernel/ipkernel.py:162: error: Unused "type: ignore" comment
[unused-ignore]
                import appnope  # type:ignore[import-untyped]
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Found 3 errors in 3 files (checked 48 source files)

It seem to be just --install-types

$ git diff ; pre-commit run --all-files --hook-stage manual mypy
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 62514712..e56cd12c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -44,7 +44,7 @@ repos:
     hooks:
       - id: mypy
         files: ipykernel
-        args: ["--install-types", "--non-interactive"]
+        args: ["--install-types"]
         additional_dependencies:
           [
             "traitlets>=5.13",
mypy.....................................................................Passed

I also get way more errors running mypy manually, but I think this is because of missing dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant