Action Bools go bye bye, hello Action Enum #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts with the action declaration, flags, and a few adjustments. Currently only done for hip drops
We weren't using the .qtn files, now we do
Update this to use action flags
This removes the boolean for IsDrilling and IsGroundpounding and replaces them with the setPlayerAction
This adds in 2 new flags and a few missing actions
Replaces the skidding boolean with the player action
This is part one, I'll do part two later
This adds a new method called checkActionFlags that should make it less convoluted
We now have the hasActionFlags method, use it over (mario->actionFlags & <actionFlag>) != 0
This adds in a Pipe action, and makes the Bobomb use the IsShelled action flag
the old system used a bool called "weak"
This adds in a new flag called "Camera Change" as well as fixing problems
SetPlayerAction now uses Frame f, and Knockback now uses the actionArg for how many stars to drop and the direction
these are new methods for MarioPlayer
This implements the "Check Entity Bounce" method
Mini Ground Pound has been added. It is like the regular one except it doesn't have the NoPlayerBounce flag
You heard me right, a new system for handling actions
Main ones being SetPlayerAction now making the Frame MANDATORY, PreActionInput and the Bounce action now being added
we're getting rid of ->DoEntityBounce and replacing it with an action
now uses PlayerAction.Bounce
... and... adjustments to JumpHandler
This is the beginning of the hold actions
It's a mess
|
holy shit 75 coommits |
|
Joe Ben |
|
pfft, that sucked |
Wallkicks now work as intended
Adds a new method called EnableSpinner as well as a few fixes
This commit focuses on the death aspect, removing the player delete from Respawn and putting it into the Death Action instead. It also now speeds up the star drop rate for every 10 stars that drop.
Just a change to speeding up every 5 stars
Fix the hip drop check so it properly functions, and do a bit of fixing of the Blue Shell
I'm Isaac Newton, mainly physics stuff
Removes the BreaksBlocks and Strong Action flags in favor of the new StompPowerLevel int. A bunch of mini mushroom checks are also removed for the StompPowerLevel.
First off, I don't know what I was thinking, why the hell did I make StompPower an int instead of an enum smh smh. Second off, starting to make water actions also an enum
We now have water actions! Let's use 'em!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically what I'm trying to do is get rid of ALL action booleans and uses a new action system to handle things like Propeller Spinning and stuff.