Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent storage for the cluster? #80

Open
leseb opened this issue Oct 17, 2022 · 2 comments
Open

Persistent storage for the cluster? #80

leseb opened this issue Oct 17, 2022 · 2 comments

Comments

@leseb
Copy link

leseb commented Oct 17, 2022

Hi,

I have a few questions as I glanced through the code :)

  1. What is backing IpfsStorage and ClusterStorage? I saw "cluster-storage" but I'm not sure where it is coming from
  2. Will it be easier to pass v1.PersistentVolumeClaim to both IpfsStorage and ClusterStorage for more flexibility?

Thanks!

@coryschwartz
Copy link
Collaborator

Hi @leseb,

These values are used to create a VolumeClaimTemplates which will create a PersistentVolumeClaim for the each instance.

The PVC template is generated here:
https://github.com/ipfs-cluster/ipfs-operator/blob/main/controllers/statefulset.go#L297

Currently, we're just asking for the size and using the default volume driver for the cluster. This is flexible in the sense that it's likely to successfully create a volume in any k8s installation, but you're right that there isn't much user configurability at the moment if they want to use a different CSI.

This is something we can look at in the future, espeically if there are users who want to use some other storage layer than what is available from their provider.

@leseb
Copy link
Author

leseb commented Oct 19, 2022

Hi @coryschwartz

As suspected indeed, the default SC will be used, thanks for the clarification.
I believe flexibility will be a plus, thanks for considering this as a future enhancement :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants