failed to commit block 21910804

[dustinxie]

What version of iotex-core image (or code branch) are you using?

latest

What operating system and processor architecture are you using?

macOS/Linux

What did you do? If possible, provide a recipe for reproducing the error.

as title, full-node failed to commit block 21910804

Root-cause

The culprit tx is https://iotexscan.io/tx/9d5bd12aa6b8bf7bc803b253f2dcc26abcd6980fa953491b1270dfdfbf64aacb, which is a CandidateUpdate but with empty name. It triggers the following error

func (cu *CandidateUpdate) SanityCheck() error {
    if !IsValidCandidateName(cu.Name()) {
        return ErrInvalidCanName
    }
    return nil
}

the check code is added by #3705, and was included in v1.10.0 release on Mar 23, 2023, which happened after the culprit tx

[envestcc]

#4564 is also required to prevent this from happening again