Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a convert tool between bech32 and hex #1502

Open
wants to merge 16 commits into
base: shimmer-develop
Choose a base branch
from

Conversation

hackphobic
Copy link
Collaborator

Description of change

Added a conversion tool between Bech32, Hex and public key encoding.

Links to any relevant issues

#263

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

I included 3 unit tests for each function. The conversions are available in the spec page https://github.com/iotaledger/tips/blob/main/tips/TIP-0011/tip-0011.md

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you fix the clippy warnings please?

@hackphobic
Copy link
Collaborator Author

hackphobic commented Aug 29, 2022

@thibault-martinez done! the licenses test seems to be failing on one of the imported crates.

@thibault-martinez
Copy link
Member

@thibault-martinez done! the licenses test seems to be failing for one of the imported crate.

Yeah don't worry about that. I'll review tonight or tomorrow, thanks.

bee-node/bee-node/src/tools/convert.rs Outdated Show resolved Hide resolved
bee-node/bee-node/src/tools/convert.rs Outdated Show resolved Hide resolved
bee-node/bee-node/src/tools/convert.rs Outdated Show resolved Hide resolved
bee-node/bee-node/src/tools/convert.rs Outdated Show resolved Hide resolved
bee-node/bee-node/src/tools/convert.rs Outdated Show resolved Hide resolved
hackphobic and others added 7 commits September 5, 2022 17:40
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
Co-authored-by: Thibault Martinez <thibault.martinez.30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants