Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video initialized check for console #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pan7
Copy link

@Pan7 Pan7 commented Jul 27, 2016

@llbraughler
Copy link

Maybe you could explain in your commit summary why this is the wrong check to use, and what effects it may have had?

@Pan7
Copy link
Author

Pan7 commented Jul 28, 2016

You can't know the linewidth/video is not initialized by checking the variable "width" but by checking "con.linewidth". Don't know what it affects.

@smcv
Copy link

smcv commented Sep 25, 2016

@Pan7: I think @llbraughler was asking you to amend the commit message (and re-push your branch) so that the commit is self-contained and justifies the change, without a later reader having to refer to this Github pull request to understand it (the PR might not even exist any more, if Github becomes less popular in a few years' time and ioquake3 moves elsewhere).

http://chris.beams.io/posts/git-commit/ has some great notes on what makes a good git commit message.

@Pan7 Pan7 changed the title Fix wrong check Fix video initialized check for console Sep 27, 2016
Base automatically changed from master to main February 10, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants