Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve distribution of machines #419

Open
mcbenjemaa opened this issue Feb 17, 2025 · 1 comment
Open

Improve distribution of machines #419

mcbenjemaa opened this issue Feb 17, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request kind/feature

Comments

@mcbenjemaa
Copy link
Member

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Currently, we distribute the nodes via ProxmoxCluster.spec.allowedNodes but this field won't help us to distribute the machines into different Proxmox hardware nodes.
We need to extend the way of placing machines so we could have a Node pool per zone or something.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

I have a proposal that I have discussed with our colleagues.

Proposal

Add a field in ProxmoxMachine and ProxmoxMachineTemplatespec.allowedNodes.
this field will override the way of distributing the nodes for this certain Machine, MachineDeployment.

spec:
  allowedNodes:
  - pve1
  - pve2
  - pve3

If ProxmoxMachine sets the allowedNodes it will take precedence over the ProxmoxCluster allowedNodes.
If no allowedNodes defined in the Machine, it will use the Cluster by default.

Environment:

  • Cluster-api-provider-proxmox version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@mcbenjemaa mcbenjemaa added enhancement New feature or request kind/feature labels Feb 17, 2025
@mcbenjemaa mcbenjemaa self-assigned this Feb 17, 2025
@wikkyk
Copy link
Collaborator

wikkyk commented Feb 17, 2025

Makes sense to me. The more granular ProxmoxMachine.allowNodes overriding the more global ProxmoxCluster.allowedNodes is exactly what you'd expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants