feat(datetime): add animation to adjacent days selection #30298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- scroll animation when adjacentDay is selected;
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoaoFerreira-FrontEnd
added
package: angular
thetaPC
requested changes
Mar 24, 2025
| @@ -251,7 +251,8 @@ | |||
| * is selected should have ion-color for | |||
| * text color and be bolder. | |||
| */ | |||
| :host .calendar-day.calendar-day-active { | |||
| :host .calendar-day.calendar-day-active, | |||
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active { | |||
There was a problem hiding this comment.
Suggested change
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active { | |
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active { |
| @@ -117,7 +117,8 @@ | |||
| * is selected should have ion-color for | |||
| * text color and be bolder. | |||
| */ | |||
| :host .calendar-day.calendar-day-active { | |||
| :host .calendar-day.calendar-day-active, | |||
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active{ | |||
There was a problem hiding this comment.
Suggested change
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active{ | |
| :host .calendar-day.calendar-day-adjacent-day.calendar-day-active { |
- simplify logic to use a targetValue const;
github-actions
bot
removed
package: angular
thetaPC
requested changes
Mar 25, 2025
- call confirm after adjacentDay is clicked;
thetaPC
requested changes
Mar 25, 2025
- add test to check ionChange value and component value returned from normal day and adjacent day;
thetaPC
requested changes
Mar 27, 2025
core/src/components/datetime/test/show-adjacent-days/index.html
Outdated
Show resolved
Hide resolved
- fix comment;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Now when an adjacent day is selected the component will scroll to the pretended month, as it does when a month change via arrow buttons.
Changes:
Does this introduce a breaking change?
Other information