feat(accordion): add skip-accordion-toggle attribute #30292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30291
What is the current behavior?
Any component that is clicked inside the
slot="header"of an Accordion component will trigger theionChangeevent if it's inside an Accordion Group.You can stop this by using
event.stopPropagation()on the component inside the Accordion header, but sometimes you require the event to bubble up, for example when using a Radio Group. In those cases, if you stop the event from bubbling, the Radio Group won't update it's value.What is the new behavior?
By adding a
skip-accordion-toggleattribute to any element inside theslot="header"it will allow the event to bubble up while skipping the accordion from being toggled.Does this introduce a breaking change?
Other information
N/A