Skip to content

[TYPING] Added typing for findForeignObject #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GermanBluefox
Copy link
Contributor

Just added types to findForeignObject

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces typing enhancements to improve type safety: it updates the Users setup file callback signature and adds new optional properties for the options parameter in the Adapter's findForeignObject function.

  • Updated prompt.get callback signature in setupUsers.ts
  • Extended the options parameter in findForeignObject with new properties in adapter.ts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/cli/src/lib/setup/setupUsers.ts Updated callback type for prompt.get for clearer error handling
packages/adapter/src/lib/adapter/adapter.ts Added additional optional properties to options for enhanced typing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant