-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Android Build Failed (Task :react-native-firebase_auth:compileDebugJavaWithJavac FAILED) #8023
[Fix] Android Build Failed (Task :react-native-firebase_auth:compileDebugJavaWithJavac FAILED) #8023
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is impossible to tell what this PR is doing since the file was reformatted
Can you push a PR that only has the functional change you desire, plus a description of what the PR is doing?
Please note that attempts to make react-native-firebase compatible with JDK < 17 are likely not functional + cannot be supported, as the various toolchains have minimum requirements of JDK17 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see - for the reasons stated in the related issue, this will fix this specific compile issue with JDK17 being required, however that will not result in a supported configuration. JDK17 is the minimum supported version and needs to be used throughout your android app build toolchains. From that perspective, removing this JDK17-specific feature is actually a developer regression, as this JDK17 feature usage results in a very fast + very obvious failure for developers indicating to them immediately that something is wrong (where "something" is: you must use JDK17)
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
JDK17 is a minimum requirement, this will not be merged, rather we have put a compile time failure in place with a descriptive error message to clearly state the minimum |
Description
In Android build getting below error before this fix: -
Tried all the solution but not working So I have done these PR changes then I am able to run build android build
Related issues
#7816