Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change android gradle source compatibility definition from 11 to 17 #8229

Open
mikehardy opened this issue Jan 14, 2025 · 0 comments
Open

Change android gradle source compatibility definition from 11 to 17 #8229

mikehardy opened this issue Jan 14, 2025 · 0 comments

Comments

@mikehardy
Copy link
Collaborator

Shouldn't be a breaking change since we already require JDK17 or we hard-fail builds...

Not sure when react-native started using AGP8+ but it may be that react-native-firebase will actually work with older react-natives using AGP7 after the PR addressing this. Not that it would imply support, but it wouldn't outright fail the build for folks attempting that


@nrtrjmly Interesting! that's a subtle interaction - missed that in previous analysis of this problem. AGP8+ has been in use long enough that I hadn't tested back far enough to attempt AGP<=8

Indeed it is kind-of-a-bug to have 11 listed for source compatibility since the code is no longer compatible with it. That should have been bumped to 17 at the same time the JDK17+ source feature was added

Originally posted by @mikehardy in #7816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant