-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable connection to S3 API for Swift, and other minor fixes #8
base: master
Are you sure you want to change the base?
Enable connection to S3 API for Swift, and other minor fixes #8
Conversation
In case you're wondering why I didn't leave an empty string as the default value of Also I just realized that this partially overlaps with #6. Sorry... |
7955060
to
e49230c
Compare
|
Hi Marco, thanks for the contribution! I hope you don't mind that I've merged already some of the changes you did, #10, they actually made sense and there was no room for discussion Regarding the ACL, I am not completely sure how to go about this, I not very inclined towards hard-codding the ACL default value, specially since we already have a default value working for AWS and other S3 compatible installations. But, for sure we can come up with a solution that makes us both happy! I am thinking, just one idea, about making a Imaging having one file there for Swift, with the class needed extending What do you think? cc @inveniosoftware/architects |
@egabancho I agree with the |
S3_SECRECT_ACCESS_KEY -> S3_SECRET_ACCESS_KEY
also add a new method open() in S3FSFileStorage, that overrides that of PyFSFileStorage, so that we can actually pass the ACL string to `S3FileSystem._open()`.
Location names with underscores are not valid.
This sets property default_block_size when creating an instance of class S3FileSystem.
e49230c
to
53ab55d
Compare
Hello. Thanks a lot for your reply. Really sorry about my delayed response. I'm absolutely happy that you decided to merge some of my changes already. I spotted a couple that are still needed, so I left them in this rebased branch. Feel free to take again what you need, it's not a problem to rebase again. As for the ACL options, I'll let you decide what's best. I would be fine with a contrib folder with specific implementations. |
@borellim I think you can go ahead and move this into |
Hello.
I made some changes to interface invenio-s3 with an S3-over-Swift compatibility API that we use. I also took the chance to fix a few misspellings. I hope this is the right way to do it, but if not I'm happy to discuss.
Changes:
S3_SIGNATURE_VERSION
(allows to use the older v2 signature protocol);S3FSFileStorage
:update()
andinitialize()
, add parameteracl
with default value'private'
;open()
that accepts a parameter'acl'
with default value'private'
;acl
toS3FileSystem._open()
viaAbstractFileSystem.open()
;S3_default
tos3-default
, as capital letters and underscores are not accepted by theinvenio files location
command;S3_ACCCESS_KEY_ID
->S3_ACCESS_KEY_ID
S3_SECRECT_ACCESS_KEY
->S3_SECRET_ACCESS_KEY
init_s3f3_info
->init_s3fs_info