Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtabmap_msgs/SensorData #1055

Merged
merged 11 commits into from
Nov 19, 2023
Merged

Add rtabmap_msgs/SensorData #1055

merged 11 commits into from
Nov 19, 2023

Conversation

matlabbe
Copy link
Member

@matlabbe matlabbe commented Oct 19, 2023

This new feature will make possible to share features extracted by visual odometry to rtabmap node (to avoid re-extracting them again) in context of multi-cameras.

Note that sharing visual odometry features to rtabmap is already possible for single camera by connecting odom_rgbd_image topic to rtabmap node (configured with subscribe_rgbd=true). See test_use_odom_features.launch. For multi-camera, it will be now possible to connect odom_sensor_data topic to rtabmap node (configured with subscribe_sensor_data=true).

odom_sensor_data would contain uncompressed data, so maybe better to use it with nodes on same computer or with rtabmap in same nodelet manager to avoid any serialization. If we only want to share features, we can set pub_sensor_data_image to false.

odom_sensor_data_compressed is also available, mainly if we want to visualize odometry result in rtabmap_viz. The image data will be compressed, so there will be an overhead on visual odometry node.

rtabmap_msgs/NodeData msg has been renamed rtabmap_msgs/Node msg and includes rtabmap_msgs/SensorData msg to avoid code duplication. This msg refactoring will also affect rtabmap_msgs/MapData msg.

Added testing script for sensor_data:rtabmap_examples/launch/test_sensor_data.launch

@matlabbe matlabbe merged commit 67de27b into master Nov 19, 2023
1 check passed
@matlabbe matlabbe deleted the add_sensor_data_msg branch November 19, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant