Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused around_the_library.html and get_random_recent_changes #9926

Conversation

siddarth2810
Copy link
Contributor

Closes #9896

refactor and cleanup

Technical

  • deleted the unused file around_the_library.html and the function get_random_recent_changes which is present in the openlibrary/plugins/upstream/utils.py
  • Verified that around_the_library.html and get_random_recent_changes were not referenced or called anywhere else in the codebase

Testing

  1. Verify that the file openlibrary/templates/site/around_the_library.html has been deleted
  2. Check openlibrary/plugins/upstream/utils.py to confirm that the function get_random_recent_changes has been removed
  3. Run the application and ensure no errors occur related to these deletions

Stakeholders

@scottbarnes

@siddarth2810
Copy link
Contributor Author

siddarth2810 commented Oct 2, 2024

Hi, my major concern was recentchanges_v2 feature flag, but after going through the code i think that deleting these files wont affect its functionality and I confirmed that /recentchanges page which is linked to this, is also working fine. So went ahead with the PR

Please let know if this is alright. Thanks !

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for this, @siddarth2810. It always feels good to delete old code. :)

Thanks also for the detailed steps you took while testing. That helps a lot.

@scottbarnes scottbarnes merged commit 634240c into internetarchive:master Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete around_the_library.html and get_random_recent_changes if unused
2 participants