Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forward author_name to edition search yet; needs full reindex #9923

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Oct 1, 2024

Side-effect I accidentally introduced in the last deploy. The author field, up until the last deploy, was kind of ignored during the edition-matching query, since the authors aren't stored on the edition. I sort of changed this during the last solr reindex, but as a result of some errors that happened, it didn't fully take effect. So now some editions in solr have authors, some don't. #8191 in assumes they do have authors, so it might be forwarding it along, causing the edition match to fail.

Technical

Testing

Screenshot

Stakeholders

@mheiman

@cdrini cdrini added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. labels Oct 1, 2024
@mekarpeles mekarpeles merged commit 0ff9050 into internetarchive:master Oct 2, 2024
3 checks passed
@mekarpeles mekarpeles self-assigned this Oct 2, 2024
@cdrini cdrini deleted the fix/authors-search branch October 2, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Patch Deployed This PR has been deployed to production independently, outside of the regular deploy cycle. Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants