fix: add localized current language to topbar #9906
Merged
+23
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to enable localization when displaying the language
If not supported, displays English (en)
for more information, see https://pre-commit.ci
cdrini
reviewed
Sep 24, 2024
| @@ -1,6 +1,9 @@ | |||
| $if not is_bot(): | |||
| $:get_donation_include() | |||
|
|
|||
| $ lang = get_lang() or 'en' | |||
| $ use_lang = lang if lang in get_supported_languages() else 'en' | |||
There was a problem hiding this comment.
Something like this should do the trick! This will (1) avoid calling gets_supported_languages() twice which is a small perf boost, and (2) make it a little clearer since we'll only have one notion of "active ui language" floating around.
Suggested change
| $ use_lang = lang if lang in get_supported_languages() else 'en' | |
| $ supported_languages = get_supported_languages() | |
| $ active_ui_lang = supported_languages.get(lang) or supported_languages.get('en') |
Then you can do:
<span>$active_ui_lang['localized'] ($active_ui_lang['code'])</span>This will require duplicating the code also inside the dictionary, but I think that's a worthwhile change! It makes all the data needed for rendering containing in the returned dictionary :)
cdrini
requested changes
Sep 24, 2024
We fetch the dictionary once to improve performance and use the code key to ensure consistency
|
All done! |
cdrini
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Lgtm, thank you @ChinoUkaegbu !
Tested:
- https://testing.openlibrary.org/status?lang=sq
- https://testing.openlibrary.org/status?lang=en
- https://testing.openlibrary.org/status?lang=fr
And all behaved correctly
cdrini
added
the
On testing.openlibrary.org
DanielleInkster
pushed a commit
to DanielleInkster/openlibrary
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs introduced in #9868
Technical
Testing
Screenshot
Stakeholders
@cdrini