Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list edits not being correctly picked up by solr updater #9759

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Aug 16, 2024

Closes #9758 .

Technical

Testing

In a local dev environment,

  1. docker compose logs --tail=10 -f solr-updater
  2. Create a new list and save it
    • ✅ The list key appears in the solr-updater output
  3. Go to http://localhost:8983/solr/openlibrary/update?commit=true to commit the changes to solr

Screenshot

image

Stakeholders

@jediD83 @benbdeitch

@github-actions github-actions bot added the Priority: 2 Important, as time permits. [managed] label Aug 16, 2024
@benbdeitch
Copy link
Collaborator

I tested this out on Gitpod, and it works like a charm. Excellent job, particularly with the refactoring!

@cdrini cdrini merged commit 74848d4 into internetarchive:master Aug 19, 2024
4 checks passed
@cdrini cdrini deleted the fix/solr-updater-lists branch August 19, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists not being correctly indexed by solr updater
2 participants