Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site-specific code for Facebook #68

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add site-specific code for Facebook #68

merged 1 commit into from
Jul 3, 2024

Conversation

CorentinB
Copy link
Collaborator

This PR adds a site-specific code to archive embed URLs for Facebook.com posts URLs.

So when an URL like this https://www.facebook.com/ernest.lowe.10/posts/10159070254449221 is detected, it generates the post.php embed URL and archive it: https://www.facebook.com/plugins/post.php?href=https%3A%2F%2Fwww.facebook.com%2Fernest.lowe.10%2Fposts%2F10159070254449221&show_text=true

@CorentinB CorentinB requested a review from equals215 July 3, 2024 09:52
@CorentinB CorentinB self-assigned this Jul 3, 2024

// Capture the embed item
err = c.Capture(embedItem)
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 levels of indentation, nice! /s
We should really rewrite the site-specific part one day

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blablabla

Copy link
Member

@equals215 equals215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CorentinB
Copy link
Collaborator Author

Thanks guys!

@CorentinB CorentinB merged commit 1381378 into main Jul 3, 2024
1 check passed
@CorentinB CorentinB deleted the facebook branch September 28, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants