-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give Zeno the logging it deserves #66
Conversation
…rkers state - untested
…ent levels, formats and outputs
…ate the best way possible what logrus do
@CorentinB your turn! |
still need to add the capacity to specify log file path, will do in the upcoming CLI rewrite PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks VERY good to me. Once the few small changes requested are done, it's good to merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Zeno logging is chaotic and need to be standardized.
The current standard for logging is
slog
as it was recently introduced in the Go standard library.multiHandler
implementsslog.Handler
interface with support for multiple outputs, currently fixed with stdout and file outputTODO :
utils.SetupLogging()
behaviour inlog
log