Remove a test that doesn't make sense in a root env (like in a Docker…

… container)
internetarchive · Jul 12, 2024 · ea748ea · ea748ea
1 parent 2abaf8e
commit ea748ea
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -22,7 +22,6 @@ jobs:
       run: go build -v ./...
 
     - name: Test
-      continue-on-error: true
       run: go test -race -v ./...
 
     - name: Goroutine leak detector

diff --git a/internal/pkg/queue/dequeue.go b/internal/pkg/queue/dequeue.go
@@ -5,6 +5,8 @@ import (
 	"io"
 )
 
+// Dequeue removes and returns the next item from the queue
+// It blocks until an item is available
 func (q *PersistentGroupedQueue) Dequeue() (*Item, error) {
 	if q.closed {
 		return nil, ErrQueueClosed

diff --git a/internal/pkg/queue/queue_test.go b/internal/pkg/queue/queue_test.go
@@ -144,16 +144,8 @@ func TestNewPersistentGroupedQueue(t *testing.T) {
 	if q.currentHost != 0 {
 		t.Error("currentHost not initialized to 0")
 	}
-
-	// Test error case: invalid directory
-	_, err = NewPersistentGroupedQueue("/invalid/path", loggingChan)
-	if err == nil {
-		t.Error("Expected error for invalid directory, got nil")
-	}
 }
 
-// In internal/pkg/queue/queue_test.go
-
 func TestPersistentGroupedQueue_Close(t *testing.T) {
 	tempDir, err := os.MkdirTemp("", "queue_test")
 	if err != nil {