Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Creating payment larger than balance has sentAmount larger than balance #1919

Open
sidvishnoi opened this issue Feb 10, 2025 · 0 comments
Labels
bug Something isn't working triage Waiting to be assigned labels

Comments

@sidvishnoi
Copy link
Member

sidvishnoi commented Feb 10, 2025

Steps to reproduce

  1. Have an account with balance, say €10.
  2. With create an outgoing payment grant with amount larger than balance, say €20.
  3. Create an outgoing payment with debitAmount larger than account balance but within grant limit.
    {
      "incomingPayment": "https://ilp.interledger-test.dev/incoming-payments/...",
      "walletAddress": "https://ilp.interledger-test.dev/...",
      "debitAmount": {
        "value": "1500",
        "assetCode": "EUR",
        "assetScale": 2
      }
    }
  4. Poll for GET /outgoing-payments/{ID}.

Expected result

sentAmount should not go beyond account balance. Outgoing payment should fail soon enough.

Actual result

    "sentAmount": {
        "value": "1485",
        "assetCode": "EUR",
        "assetScale": 2
    }

Transactions page shows outgoing payment in pending. Incoming payment shows completed!

Sending another payment (say €4) works fine after this still (within grant limit; but more than should-be remaining balance).

Screenshots or videos

Image

In screenshot: sent €15 from EUR to MXN; then sent €4 to MXN. €10 is initial deposit (last txn from bottom).

Additional context

As seen in WM extension. Created grant budget larger than account balance, then sent €15, €4 payments. Both marked as successful as polling outgoing-payment showed amount being sent.

Operating system

Windows, macOS, Linux

Operating system version

No response

Browsers

Chrome, Microsoft Edge, Firefox

Browser version

No response

@sidvishnoi sidvishnoi added bug Something isn't working triage Waiting to be assigned labels labels Feb 10, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Testnet Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Waiting to be assigned labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant