Skip to content
This repository has been archived by the owner on Sep 1, 2024. It is now read-only.

Feature/js develop/private education query controller main #215

Merged

Conversation

huseynhasanov07
Copy link
Contributor

PrivateEducationQueryHandler

…into feature/js-develop/private-education-query-controller-main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bu fayl icerisinde userQueryRepositoryAdapter field istifade olunmur silsez yaxsi olar

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api - larda get sozunu silsez daha mentiqli olar. meselen my-educations ve yaxud any-educations bele bir sey yazarsiz.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SneakyThrows silsez yaxsi olar. Xetalari handle etmeliyik. Cunki sonra nese checked exceptionlar olar ve onlari gore bilmerik. Bu da bize problem yarada biler.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bu hisseni tam tutmadim. Cunki selectByExample ve selectFirstByExample gorduyum qederile mybatis terefde eyni sorgunu isledirler. Neye esasen mueyyen edirsen ki biri list qaytaracaq amma bir denesi sadece 1 row qaytaracaq tutmadim bunu

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. private SimplePageableResponse simplePageableResponse - metodu private olduguna gore stilistika cehetden mesqede uygundur ki public metodlardan sonra yeni en sonda gelsin.

@l00pss l00pss merged commit a6b32b3 into develop May 16, 2024
0 of 2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants