[SYCL][Graph] Deprecate dynamic_parameter constructors that take a graph #18199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tying a dynamic param to a specific graph has no practical purpose and prevents whole graph update usage, so this is the first step to removing it - Remove error wording from spec about using dynamic params across multiple graphs - Deprecate old constructors and add new ones under breaking changes macro. - Ignore graph parameter for current constructors since it is no longer stored. - Update tests to ignore deprecation warnings under werror
EwanC
reviewed
Apr 25, 2025
Comment on lines
+514
to
+518
| #ifndef __INTEL_PREVIEW_BREAKING_CHANGES | ||
| __SYCL_DEPRECATED("Dynamic_parameter constructors taking a graph object have " | ||
| "been deprecated " | ||
| "and will be removed in the next ABI breaking window.") | ||
| #endif |
There was a problem hiding this comment.
Do we need this, and the same code on line 522-526
| @@ -1,4 +1,4 @@ | |||
| // RUN: %{build} -o %t.out | |||
| // RUN: %{build} -Wno-error=deprecated-declarations -Wno-error=deprecated-declarations -o %t.out | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full spec changes to detail new behaviour will be done during the next ABI breaking window when these deprecated constructors are also removed.