Skip to content

[SYCL][E2E] Enable llvm-lit to select spercific numbered device #18197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented Apr 25, 2025

Allow for selection of a specific device via the style level_zero:0 when running sycl E2E tests via llvm-lit.
Fixes an issue that can occur where multiple devices on a machine of the same platform have different supported aspects and llvm-lit only returns aspects as supported that are available on all devices of the same platform.

@DBDuncan DBDuncan requested a review from a team as a code owner April 25, 2025 13:51
@aelovikov-intel
Copy link
Contributor

What problem are you trying to solve? Empty PR description and no comments in the change don't help to understand the idea behind this.

@DBDuncan
Copy link
Contributor Author

DBDuncan commented Apr 25, 2025

Ah sorry. You are right. The issue is that on devices with say a battlemage GPU and an intel intergrated iGPU, when running llvm-lit with --param sycl_devices="level_zero:gpu" set, when sycl/test-e2e/lit.cfg.py is sorting out which aspects are enabled, it only signals aspects as supported to // REQUIRES: aspect- that are supported on all intel devices listed via level_zero:gpu from sycl-ls.

This is a problem with bindless images as the aspect exp_oneapi_bindless_images is not supported on intel iGPUs, but even if the tests are running on a supported device because that device comes first in the list it will not run them because the aspect in tests returns the feature as unsupported.

Currently, sycl/test-e2e/lit.cfg.py does not support the level_zero:0/1/2/etc device selection style which would fix this issue. So patch intends to fix this allowing for explicit selection for the device, not just platform and device type.

@aelovikov-intel
Copy link
Contributor

First, that should go to the PR description, not the comment. Second, please add an example usage, e.g., sycl-ls shows this, we run llvm-lit like that, and it does the following (and print detected aspects from its output).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants