[UR][HIP] Unbundle hip conformance test binaries #18184
Conversation
The binaries used for conformance testing on hip are generated using SYCL programs which output a "bundled object" rather than a raw amdhsa binary. This unbundles the objects so that the HIP conformance tests are given the raw binaries.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
requested review from
a team,
npmiller and
jchlanda
and removed request for
a team and
npmiller
|
@intel/llvm-reviewers-cuda Apologies if you aren't the right team for this, but could I get eyes on this? There seems to be two main types of binaries that the hip backend can accept: An "offload bundle" and a raw elf. Offload doesn't seem to support the "offload bundle", so this change switches to using the raw elf for testing. If I understand correctly, there should be no real difference between the actual binary data or behaviour. |
|
Yes, that's the right team. The change looks good to me, although I believe SYCL is passing the "offload bundle" version to the ur adapters at the moment. Wouldn't the proper fix be to make offload also support that, what do you think? But I don't really know how offload works currently, so I'm happy to go with that for now if it makes more sense. |
The binaries used for conformance testing on hip are generated using
SYCL programs which output a "bundled object" rather than a raw amdhsa
binary. This unbundles the objects so that the HIP conformance tests are
given the raw binaries.