Add struct for mapping ibpi statuses to strings. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtkaczyk
force-pushed
the
mtkaczyk_fix_ibpi2str
branch
from
989d54a to
2fc0eec
Compare
bkucman
requested changes
Apr 9, 2024
This is done different way in multiple places. Add one structure to lib and make in commonly used. Differentiate input values and logged values, not all patterns can be set but all patterns should be logged. This simplifies implementation, there is no need to handle temporary buf strings for generating "(unknown: %d)" messages. Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
mtkaczyk
force-pushed
the
mtkaczyk_fix_ibpi2str
branch
from
2fc0eec to
1504bde
Compare
bkucman
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done different way in multiple places. Add one structure to lib and make in commonly used. Differentiate input values and logged values, not all patterns can be set but all patterns should be logged.
This simplifies implementation, there is no need to handle temporary buf strings for generating "(unknown: %d)" messages.
Fixes #198