Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore assert with SES and testing "rebuild" state #207

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

tasleson
Copy link
Contributor

The SES hardware accepts the pattern, but we don't have a way to read it back for a comparison.

Resolves: #201

We don't have a way to retrieve the state sent down to the hardware
when we use states other than the most basic ones which illuminate
the locate or fault LED.

Signed-off-by: Tony Asleson <tasleson@redhat.com>
@tasleson tasleson changed the title Ignore assert when SES and using "rebuild" Ignore assert with SES and testing "rebuild" state Feb 21, 2024
Copy link
Contributor

@bkucman bkucman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just please update date in file header # Copyright (C) 2023 Red Hat Inc.

Use word "beneficial".

Note: Also update copyright date.

Signed-off-by: Tony Asleson <tasleson@redhat.com>
@tasleson
Copy link
Contributor Author

LGTM, just please update date in file header # Copyright (C) 2023 Red Hat Inc.

Done, thanks

@mtkaczyk mtkaczyk merged commit f2e70e7 into intel:master Feb 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/runtests.sh failure when testing SES
3 participants