Skip to content

Commit

Permalink
Change polarity of RayQueryDynamicRayManagment opt flag/ail
Browse files Browse the repository at this point in the history
Originally opt enabled by default but due to several func issues (game crashes) and minimal perf benefit plan is to disabled this opt by default (and enable via AIL if needed)
  • Loading branch information
pepla authored and igcbot committed Jan 31, 2025
1 parent 757f50a commit 185115e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion IGC/AdaptorCommon/RayTracing/RayTracingInterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ void RayTracingInlineLowering(CodeGenContext* pContext)
if (IGC_IS_FLAG_ENABLED(OverrideTMax))
mpm.add(createOverrideTMaxPass(IGC_GET_FLAG_VALUE(OverrideTMax)));

if (pContext->platform.isDynamicRayQueryDynamicRayManagementMechanismEnabled() && !pContext->getModuleMetaData()->compOpt.DisableDynamicRQManagement)
if (pContext->platform.isDynamicRayQueryDynamicRayManagementMechanismEnabled() && pContext->getModuleMetaData()->compOpt.EnableDynamicRQManagement)
{
mpm.add(CreateDynamicRayManagementPass());
}
Expand Down
2 changes: 1 addition & 1 deletion IGC/common/MDFrameWork.h
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ enum class ShaderTypeMD
bool ForceLinearWalkOnLinearUAV = false;
bool DisableLscSamplerRouting = false;
bool UseBarrierControlFlowOptimization = false;
bool DisableDynamicRQManagement = false;
bool EnableDynamicRQManagement = false;
unsigned Quad8InputThreshold = 0;
bool UseResourceLoopUnrollNested = false;
};
Expand Down
2 changes: 1 addition & 1 deletion IGC/common/igc_flags.h
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ DECLARE_IGC_GROUP("Raytracing Options")
DECLARE_IGC_REGKEY(bool, EnableRTPrintf, false, "Enable printf for ray tracing.", true)
DECLARE_IGC_REGKEY(DWORD, PrintfBufferSize, 0, "Set printf buffer size. Unit: KB.", true)
DECLARE_IGC_REGKEY(bool, DisableRayQueryReturnOptimization, false, "RayQuery Return Optimization", true)
DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanism, false, "Dynamic ray management mechanism for Synchronous Ray Tracing", true)
DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanism, true, "Dynamic ray management mechanism for Synchronous Ray Tracing", true)
DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanismForExternalFunctionsCalls, false, "Disable dynamic ray management mechanism for shaders with external functions calls", true)
DECLARE_IGC_REGKEY(bool, DisableRayQueryDynamicRayManagementMechanismForBarriers, false, "Disable dynamic ray management mechanism for shaders with barriers", true)
DECLARE_IGC_REGKEY(bool, EnableOuterLoopHoistingForRayQueryDynamicRayManagementMechanism, false, "Disable dynamic ray management mechanism for shaders with barriers", true)
Expand Down

0 comments on commit 185115e

Please sign in to comment.