Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ish-pm: support GPIO both edge interrupt #36

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

lifenggitacc
Copy link
Contributor

Change-Id: I471a20c61fa2d3085e96e901af6afc6be72a77be

ISH by its design doesn't support interrupt configuration both edge trigger; if configure both edge, in lower power mode, ISH will enter then exit LPM immediately. This causes insufficient LPM residency.
However in Chrome project, some GPIO pins have to support both edge interrupt. To keep LPM function intact and also meet the requirements of Chrome project, we provide this alternative solutions. In general, before entering LPM, reconfigure interrupt with single edge, which is the expected next triggering edge; after exit from LPM, restore original value.
Originally this was implemented in Chrome WHL ECOS ISH project; link is here: https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/chip/ish/power_mgt.c#299

Change-Id: I471a20c61fa2d3085e96e901af6afc6be72a77be
Signed-off-by: Li Feng <li1.feng@intel.com>
@likongintel
Copy link
Contributor

There are 2 concerns from hebo
• License:
o Both Chrome EC and Intel SEDI used BSD license, I think overall should have no problem, but Chrome EC license file mentioned:

Maybe we need include ChromiumOS’s license notice also.

• GPIO Groups (or Ports):
o ISH5.8 has two GPIO groups, this code (original based on ISH5.0, only have single group) only handled the first group, if user used pins from the second group, then will have problem, we need implement for both groups as a complete solution.

@likongintel likongintel merged commit e69df34 into intel:main Mar 29, 2024
2 checks passed
@lifenggitacc
Copy link
Contributor Author

Thanks. Agree a complete solution should be implemented to support newer ISH verison.

@lifenggitacc lifenggitacc deleted the pm-fix-int-both-edge branch March 30, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants