Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split kusama/polkadot runtimes #303

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

split kusama/polkadot runtimes #303

wants to merge 23 commits into from

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Nov 19, 2024

reasons:

  • for now, we'll keep sudo on polkadot (until bridge is publicly enabled)
  • relay location needs to be hard-coded for proper XCM setup

checks

  • state migrations are complete for polkadot too (v43 to v550). including collator-selection
  • chopsticks runtime upgrade.
    • npx @acala-network/chopsticks@latest --config ~/chopsticks/configs/integritee-polkadot.yml --wasm-override ~/integritee/bin/1.13.2-v550-polkadot/integritee_polkadot_runtime.compact.compressed.wasm
    • collator set ok
    • tx works
    • spec version: 550
    • try again with new runtime spec_name
      • Events are not shown in Network view, but execution is complete
  • double-check SE: https://substrate.stackexchange.com/questions/12047/what-to-consider-when-changing-a-parachains-spec-name
  • test upgrade on paseo ( use integritee-kusama)
    • does the spec_name change lead to any trouble?
  • re-enable spec version check in migrations CI

disclaimer

  • this change is only really complete for runtimes. generation of genesis specs is not updated and will still default to integritee-kusama. However, we should deprecate our own client in favor of omni-node anyway

@brenzi brenzi requested a review from clangenb November 19, 2024 13:21
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some tiny questions, looks good otherwise.

polkadot-parachains/integritee-polkadot/src/xcm_config.rs Outdated Show resolved Hide resolved
scripts/benchmark_all_pallets.sh Outdated Show resolved Hide resolved
polkadot-parachains/src/service.rs Show resolved Hide resolved
polkadot-parachains/src/command.rs Show resolved Hide resolved
polkadot-parachains/src/command.rs Show resolved Hide resolved
polkadot-parachains/src/chain_spec.rs Show resolved Hide resolved
polkadot-parachains/integritee-polkadot/src/migrations.rs Outdated Show resolved Hide resolved
@brenzi
Copy link
Collaborator Author

brenzi commented Nov 20, 2024

triggered 1.13.3-dev to test build on Paseo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants